Skip to content

Comments

[MNG-8670] Fix concurrent builder missing/wrong project events#2251

Merged
gnodet merged 2 commits intoapache:masterfrom
oehme:oehme/project-events
Apr 30, 2025
Merged

[MNG-8670] Fix concurrent builder missing/wrong project events#2251
gnodet merged 2 commits intoapache:masterfrom
oehme:oehme/project-events

Conversation

@oehme
Copy link
Contributor

@oehme oehme commented Apr 8, 2025 •
edited by cstamas
Loading

Rather than adding another test, I've expanded on the one I previously
wrote for ProjectStarted events.

https://issues.apache.org/jira/browse/MNG-8670

@cstamas
Copy link
Member

cstamas commented Apr 9, 2025

Source formatting issues make ITs fail. @oehme

@oehme
[MNG-8670] Test case for missing/wrong project events
44dba0d 
Rather than adding another test, I've expanded on the one I previously
wrote for ProjectStarted events.
@oehme oehme force-pushed the oehme/project-events branch from 6705c75 to 44dba0d Compare April 9, 2025 15:12
@cstamas
Copy link
Member

cstamas commented Apr 11, 2025 •
edited
Loading

Cool! JIRA mentions ProjectSkipped, does it mean we lack other events as well?

[INFO] Running org.apache.maven.it.MavenITmng8648ProjectEventsTest
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.916 s <<< FAILURE! -- in org.apache.maven.it.MavenITmng8648ProjectEventsTest
Error:  org.apache.maven.it.MavenITmng8648ProjectEventsTest.test -- Time elapsed: 1.914 s <<< ERROR!
org.apache.maven.it.VerificationException: Text not found in log: org.apache.maven.its.mng8648:root:pom:1-SNAPSHOT ProjectSucceeded
	at org.apache.maven.it.Verifier.verifyTextInLog(Verifier.java:445)
	at org.apache.maven.it.MavenITmng8648ProjectEventsTest.test(MavenITmng8648ProjectEventsTest.java:52)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

@oehme
Copy link
Contributor Author

oehme commented Apr 11, 2025

The reason I mentioned ProjectSkipped was because the root project is listed as "Skipped" on the command line when using the concurrent builder, but gets no event. However, when I run this with the traditional builder, the root project is marked as "Successful" instead and gets a success event. I created the test with this behavior as my template.

I don't really mind which way you go (mark it as skipped or mark it as successful), as long as it gets an event :)

For project-d, the behavior is similarly inconsistent. It gets no events at all with the old builder and it is marked as "successful" with the new builder, which seems wrong, since it depends on a failed project.

@gnodet gnodet force-pushed the oehme/project-events branch from 36f58e6 to 6be4d44 Compare April 24, 2025 20:45
@gnodet gnodet marked this pull request as ready for review April 25, 2025 09:12
@gnodet gnodet changed the title [MNG-8670] Test case for missing/wrong project events [MNG-8670] Fix concurrent builder missing/wrong project events Apr 25, 2025
@gnodet gnodet added this to the 4.0.0-rc-4 milestone Apr 25, 2025
@gnodet gnodet requested a review from cstamas April 30, 2025 11:46
@gnodet gnodet merged commit 3706aa1 into apache:master Apr 30, 2025
13 checks passed
@jira-importer
Copy link

jira-importer commented Jul 7, 2025

Resolve #9636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstamas cstamas cstamas approved these changes

Assignees

@gnodet gnodet

Labels

maintenance

Projects

None yet

Milestone

4.0.0-rc-4

Development

Successfully merging this pull request may close these issues.

4 participants

@oehme @cstamas @jira-importer @gnodet